go mod: script to get a usable mod version from a tag to use in a go.mod #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11477 +/- ##
==========================================
+ Coverage 64.2% 65.57% +1.36%
==========================================
Files 403 402 -1
Lines 38085 36686 -1399
==========================================
- Hits 24453 24056 -397
+ Misses 12005 11108 -897
+ Partials 1627 1522 -105
Continue to review full report at Codecov.
|
riptl
reviewed
Mar 15, 2020
add go.etcd.io/etcd@ to the version for go get Co-Authored-By: Richard Patel <me@terorie.dev>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Dec 3, 2020
Due to botched upstream renames of project repositories and incomplete migration to go.mod support, our current dependency version of `go.mod` had bugs i.e it was using commits from master branch which didn't have the required fixes present in release-3.4 branches which leads to some rare bugs etcd-io/etcd#11477 provides a workaround for now and we should migrate to this. release-3.5 eventually claims to fix all of this properly until then we cannot use /v3 import right now
6 tasks
harshavardhana
added a commit
to minio/minio
that referenced
this pull request
Dec 3, 2020
Due to botched upstream renames of project repositories and incomplete migration to go.mod support, our current dependency version of `go.mod` had bugs i.e it was using commits from master branch which didn't have the required fixes present in release-3.4 branches which leads to some rare bugs etcd-io/etcd#11477 provides a workaround for now and we should migrate to this. release-3.5 eventually claims to fix all of this properly until then we cannot use /v3 import right now
jsloyer
pushed a commit
to IBM-Cloud/go-etcd-rules
that referenced
this pull request
May 26, 2021
Workaround etcd-io 3.4 go.mod issue etcd-io/etcd#11154 using script etcd-io/etcd#11477 Related https://github.ibm.com/alchemy-containers/armada-ballast/issues/265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is impossible to import
go.etcd.io/etc v3.X.Y. This script finds the correspondingv0.0.0-...-...from a tag so that it can be included in a project'sgo.mod.Fixes #11154 #11336 #11472